[PATCH] D70465: [Win64] Handle FP arguments more gracefully under -mno-sse

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D70465#1752671 <https://reviews.llvm.org/D70465#1752671>, @efriedma wrote:

> I'm not opposed to supporting a soft-float ABI.  But I don't think -mno-sse is a strong enough signal that the user actually understands what they're asking for, as opposed to being an accidental leftover from a 32-bit project.  I'd prefer to print an error.


Well, -mno-sse seems to be enough to get GCC to do a soft-floatish thing, so I'm really just trying to follow them here. I think what we're finding in practice is that simply implementing the functionality we didn't intend to support is actually easier than nailing down the corner cases under which we should emit an error and recovering correctly.

In D70465#1752668 <https://reviews.llvm.org/D70465#1752668>, @craig.topper wrote:

> Isn't this passing by memory not by X87?


You're right, it was. Now it converts to i32/i64, which goes via RCX/RDX/etc then stack memory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70465/new/

https://reviews.llvm.org/D70465