[PATCH] D69059: [SVE][AArch64] Adding patterns for while intrinsics

Tue Nov 19 15:37:09 PST 2019

efriedma accepted this revision.
efriedma added a comment.

LGTM

================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1506
+  defm WHILEHS_PXX : sve_int_while8_rr<0b100, "whilehs", null_frag>;
+  defm WHILEHI_PXX : sve_int_while8_rr<0b101, "whilehi", null_frag>;
+
----------------
mgudim wrote:
> efriedma wrote:
> > Why are you using null_frag here?
> > 
> > Also, there aren't any tests for whilege/whilegt/whilehs/whilehi.
> I did not want to touch SVE2 intrinsics, I changed these lines accidentally, sorry about that.  The `null_frag` is necessary for `.td` files to compile since I changed the definitions of the multiclasses.
Oh, I missed that the ge/gt/hs/hi variants are only part of SVE2.  I guess that's okay for now, then.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69059/new/

https://reviews.llvm.org/D69059