[PATCH] D69674: [FIX] Make LSan happy by *not* leaking memory

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 15:19:00 PST 2019


dblaikie added a comment.

Looks like this was sent for review but no one reviewed/approved it? Generally, if something is sent for review, it's not great to submit it without review. (if you felt it needed review to begin with, time shouldn't change that)

Any chance of using unique_ptrs here, instead of raw pointers and DeleteContainerPointers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69674/new/

https://reviews.llvm.org/D69674





More information about the llvm-commits mailing list