[PATCH] D70463: [LTO][Legacy] Add API for passing LLVM options separately

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 15:00:52 PST 2019


steven_wu added a comment.

LGTM with one nitpick.



================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:633
 
+void LTOCodeGenerator::setCodeGenDebugOptions(ArrayRef<const char *> Options) {
+  for (StringRef Option : Options)
----------------
Maybe it would be cleaner if remove the old setCodeGenDebugOptions implementation and make the old C API to build an array and call the new interface?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70463/new/

https://reviews.llvm.org/D70463





More information about the llvm-commits mailing list