[PATCH] D69772: [APFloat] Fix subtraction of subnormal numbers

[Jay Foad via Phabricator via llvm-commits]

foad added a reviewer: foad.
foad added a comment.

LGTM.

Would you mind adding a fused multiply-add test case like the one from bug 44010?



================
Comment at: llvm/lib/Support/APFloat.cpp:1549
 
-    if (bits == 0) {
-      reverse = compareAbsoluteValue(temp_rhs) == cmpLessThan;
-      lost_fraction = lfExactlyZero;
-    } else if (bits > 0) {
+    if (bits > 0) {
       lost_fraction = temp_rhs.shiftSignificandRight(bits - 1);
----------------
The diff would be smaller if you left these tests in the same order :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69772/new/

https://reviews.llvm.org/D69772