[PATCH] D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 13:20:14 PST 2019


dexonsmith closed this revision.
dexonsmith added a comment.

In D70285#1752361 <https://reviews.llvm.org/D70285#1752361>, @dexonsmith wrote:

> In D70285#1752164 <https://reviews.llvm.org/D70285#1752164>, @Bigcheese wrote:
>
> > lgtm as long as other compilers don't warn on unknown pragmas by default.
>
>
> godbolt.org says that GCC doesn't have `-Wunknown-pragmas` by default, but it is in `-Wall`.  I'd better guard this more closely with `__clang__`.


Pushed as 8c48405069085a2c8b6b80816eda99e5dad31fc1 <https://reviews.llvm.org/rG8c48405069085a2c8b6b80816eda99e5dad31fc1> with this fixup.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70285/new/

https://reviews.llvm.org/D70285





More information about the llvm-commits mailing list