[PATCH] D69740: [profile] Support counter relocation at runtime

Tue Nov 19 12:52:37 PST 2019

vsk added a comment.

I think this looks good overall. The only high-level item that seems to be missing is Fuchsia testing -- are there any bots for this?

I've left inline comments about fixing up some tests. Please also leave a comment about Fuchsia/-runtime-counter-relocation in clang/docs/SourceBasedCodeCoverage.rst.

================
Comment at: compiler-rt/lib/profile/InstrProfiling.h:315
+ */
+COMPILER_RT_VISIBILITY extern intptr_t __llvm_profile_counter_bias;
+
----------------
Could you add `__llvm_profile_counter_bias` to clang's Darwin::addProfileRTLibs, to appease tapi? This will prevent breakage in the instrprof-darwin-exports.c test.

================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:102

+COMPILER_RT_VISIBILITY int RuntimeCounterRelocation = 0;
+
----------------
I believe this adds a dependency from InstrProfilingBuffer.c onto InstrProfilingFile.c onto, which I think breaks the instrprof-without-libc test. I think `RuntimeCounterRelocation` needs to live in InstrProfilingBuffer.c.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69740/new/

https://reviews.llvm.org/D69740