[PATCH] D70367: Fix for AMDGPU MUL_I24 known bits calculation

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

The logic looks correct to me.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:4455
+
+      if((LHSNonNegative && RHSNonNegative) || (LHSNegative && RHSNegative))
         Known.Zero.setHighBits(32 - MaxValBits);
----------------
Space between "if" and "(".


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:4457
         Known.Zero.setHighBits(32 - MaxValBits);
+      else if((LHSNegative && RHSPositive) || (LHSPositive && RHSNegative))
+        Known.One.setHighBits(32 - MaxValBits);
----------------
Likewise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70367/new/

https://reviews.llvm.org/D70367