[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist
Jan Korous via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 11:29:30 PST 2019
jkorous added inline comments.
================
Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:100
+ Contains(StrEq(std::string("-fsanitize-system-blacklist=") +
+ ASanBlacklist)));
+ // User blacklists should also be added.
----------------
ilya-biryukov wrote:
> I'm pretty sure this is going to fail on Windows, looking for ideas on how to unify this with minimal code...
> Let me know if there's some cool trick for this that I should know...
Would `llvm::sys::path::convert_to_slash()` help?
================
Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:133
+} // namespace
\ No newline at end of file
----------------
Nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70440/new/
https://reviews.llvm.org/D70440
More information about the llvm-commits
mailing list