[PATCH] D70413: [musttail] Don't forward incoming registers over call site registers

Andrew Paverd via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 10:34:05 PST 2019


ajpaverd added a comment.

Thanks for finding and fixing this @rnk! I've double-checked that Windows doesn't use `AL`  for varargs (https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention?view=vs-2019#varargs), but having a general mechanism for forwarding that doesn't assume a particular calling convention sounds like a good approach. This looks good from the control flow guard perspective.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70413/new/

https://reviews.llvm.org/D70413





More information about the llvm-commits mailing list