[PATCH] D70121: [WIP][DebugInfo][LDV] Attempt to teach LDV how to handle fragments

[Tom Weaver via Phabricator via llvm-commits]

TWeaver added a comment.

some super nits. Patch is huge and difficult to parse, will require several passes I feel.



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:101
+/// don't have the same expression. In addition, a nullptr Expression and undef
+/// location represents a dummy blocker value. This is acts like an undef except
+/// it will not be emitted as a DBG_VALUE.
----------------
'This is acts'

should be

'This acts'

?


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:110
 
-  unsigned locNo() const {
-    // Fix up the undef location number, which gets truncated.
-    return LocNo == INT_MAX ? UndefLocNo : LocNo;
-  }
-  bool isUndef() const { return locNo() == UndefLocNo; }
+  /// May return nullptr if this is a dummy value.
+  const DIExpression *getExpression() const { return Expression; }
----------------
'May return nullptr'

Should be

'Will return nullptr'

or is there a case where it can be a dummy value and not return a nullptr?


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:328
+
+  /// The debug info variable we are part of.
+  const DILocalVariable *Variable;
----------------
We refer to? We point to?

not sure "are part of" is quite the right description here.

bit nitty I know...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70121/new/

https://reviews.llvm.org/D70121