[PATCH] D70148: [SLP] fix miscompile on min/max reductions with extra uses (PR43948)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D70148#1751608 <https://reviews.llvm.org/D70148#1751608>, @spatel wrote:

> The result of the function is based on that value, so we can get the whole thing wrong depending on what we choose for 'undef'.


In case that's not clear because SLP leaves dead code everywhere - if you pass the output of SLP to instcombine:

  define i1 @bad_insertpoint_rdx([8 x i32]* %p) #0 {
    ret i1 false
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70148/new/

https://reviews.llvm.org/D70148