[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

[Paul Mulders via Phabricator via llvm-commits]

justinkb reopened this revision.
justinkb added a comment.
This revision is now accepted and ready to land.
Herald added a project: LLVM.

The check doesn't work correctly if LLVM is built as a dylib and the LLVMTestingSupport static library isn't installed (which it normally wouldn't be)

On my machine llvm-config --components (correctly) doesn't print testingsupport, but since llvm-config --libs "testingsupport" does return "-lLLVM-9" since "If LLVM_LINK_DYLIB is ON, the single shared library will be return for "--libs" (quote from llvm-config source). Since testingsupport never seems to get built into the dylib, we end up with the failing check.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55891/new/

https://reviews.llvm.org/D55891