[PATCH] D59035: [X86] Promote i8 CMOV's (PR40965)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 05:26:48 PST 2019
lebedev.ri marked 2 inline comments as done.
lebedev.ri added inline comments.
================
Comment at: llvm/trunk/test/CodeGen/X86/cmov.ll:190
; Don't try to use a 16-bit conditional move to do an 8-bit select,
; because it isn't worth it. Just use a branch instead.
define i8 @test7(i1 inreg %c, i8 inreg %a, i8 inreg %b) nounwind {
----------------
nick wrote:
> The comment should have been removed?
Indeed, fixed in 6de85095ed7d8f161a7f39422d42b5bc2d2dcb98, thanks!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59035/new/
https://reviews.llvm.org/D59035
More information about the llvm-commits
mailing list