[PATCH] D69168: [PowerPC] Fold redundant load immediates of zero and delete if possible
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 04:41:28 PST 2019
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM except for formatting nits. Thanks for addressing the comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1328
+bool PPCInstrInfo::onlyFoldImmediate(MachineInstr &UseMI, MachineInstr &DefMI,
+ unsigned Reg) const {
// A zero immediate should always be loaded with a single li.
----------------
Similar issue with alignment.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:311
+ bool onlyFoldImmediate(MachineInstr &UseMI, MachineInstr &DefMI,
+ unsigned Reg) const;
+
----------------
Minor nit: alignment of the last parameter is off, please fix on the commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69168/new/
https://reviews.llvm.org/D69168
More information about the llvm-commits
mailing list