[PATCH] D69777: [ConstantFolding] Fold calls to FP remainder function

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Analysis/ConstantFolding/math-2.ll:31
+}
+
 declare double @pow(double, double)
----------------
ekatz wrote:
> arsenm wrote:
> > ekatz wrote:
> > > arsenm wrote:
> > > > Should have tests stressing all the handled types , and preferably a few for the special cases , like snan 
> > > I agree that it should be tested for `double` as well, but the test cases are not important, as we test them under the APFloat unit-test. Otherwise, we will just have duplicates in the implementation code and the using code.
> > The code specifically checks for opStatus though, so the point isn't necessarily then folding result
> The APFloat unit test is also testing various combination of operations' results.
But not in this usage context. The behavior here is changing based on it, so the point isn't testing what the opStatus is


================
Comment at: llvm/test/Analysis/ConstantFolding/math-2.ll:37
+;
+  %res = tail call fast double @remainder(double 1.0, double 2.0)
+  ret double %res
----------------
also one for remainderl


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69777/new/

https://reviews.llvm.org/D69777