[PATCH] D69462: [DebugInfo]: Support for debug_loclists.dwo section in llvm and llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:189
         Data = Data.substr(C->Offset, C->Length);
-    LocTable = std::make_unique<DWARFDebugLoclists>(
-        DWARFDataExtractor(Data, isLittleEndian, getAddressByteSize()),
-        Header.getVersion());
+    LocTable = Header.getVersion() >= 5
+                   ? std::make_unique<DWARFDebugLoclists>(
----------------
I wrote this as conditional, just to avoid breaking of DWP{Prior Dwarf-5} stuff .
Notably failure of `loclists-dwp.ll` . Since this test case doesn't address DWP{Dwarf-5}. We're good here. 
Till we DWP{Dwarf-5} support.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69462/new/

https://reviews.llvm.org/D69462