[PATCH] D70429: [update_cc_test_checks.py] Add the --function-signature flag

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 03:18:15 PST 2019


arichardson created this revision.
arichardson added reviewers: jdoerfert, MaskRay.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This was added to update_test_checks.py in D68819 <https://reviews.llvm.org/D68819> and I believe having it
in update_cc_test_checks.py is also useful


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70429

Files:
  llvm/utils/update_cc_test_checks.py


Index: llvm/utils/update_cc_test_checks.py
===================================================================
--- llvm/utils/update_cc_test_checks.py
+++ llvm/utils/update_cc_test_checks.py
@@ -103,6 +103,8 @@
   parser.add_argument(
       '--x86_extra_scrub', action='store_true',
       help='Use more regex for x86 matching to reduce diffs between various subtargets')
+  parser.add_argument('--function-signature', action='store_true',
+                      help='Keep function signature information around for the check line')
   parser.add_argument('tests', nargs='+')
   args = common.parse_commandline_args(parser)
   args.clang_args = shlex.split(args.clang_args or '')
@@ -162,7 +164,7 @@
   if '-emit-llvm' in clang_args:
     common.build_function_body_dictionary(
             common.OPT_FUNCTION_RE, common.scrub_body, [],
-            raw_tool_output, prefixes, func_dict, args.verbose, False)
+            raw_tool_output, prefixes, func_dict, args.verbose, args.function_signature)
   else:
     print('The clang command line should include -emit-llvm as asm tests '
           'are discouraged in Clang testsuite.', file=sys.stderr)
@@ -288,7 +290,8 @@
             if added:
               output_lines.append('//')
             added.add(mangled)
-            common.add_ir_checks(output_lines, '//', run_list, func_dict, mangled, False, False)
+            common.add_ir_checks(output_lines, '//', run_list, func_dict, mangled,
+                                 False, args.function_signature)
       output_lines.append(line.rstrip('\n'))
 
     # Update the test file.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70429.230023.patch
Type: text/x-patch
Size: 1595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191119/5fae55ad/attachment.bin>


More information about the llvm-commits mailing list