[PATCH] D70226: Add an option to disable strict float node mutating to an normal float node

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

Thanks!   Just one minor nit about the comment inline, otherwise this patch LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2819
     // This expansion does not honor the "strict" properties anyway,
     // so prefer falling back to the non-strict operation if legal.
+    if (TLI.isStrictFPEnabled())
----------------
This comment is now duplicated; it would be better to change the comment above to something along the lines of what I suggested earlier, e.g.

```
// This expansion does not honor the "strict" properties,
// so we cannot use it if strict mode is enforced.

```


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2843
     // This expansion does not honor the "strict" properties anyway,
     // so prefer falling back to the non-strict operation if legal.
+    if (TLI.isStrictFPEnabled())
----------------
See above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70226/new/

https://reviews.llvm.org/D70226