[PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

Jan Kratochvil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 02:31:27 PST 2019 

jankratochvil added a comment.

@omjavaid I guess it depends on some system library - what OS vendor/release do you have the regression reproducible on?
Still not reproducible for me.  Trying `bfbbf0aba81a84da8b53d4d159d080e77ad8ee70` with applied D70155 <https://reviews.llvm.org/D70155> and applied/unapplied this D63540 <https://reviews.llvm.org/D63540> on Fedora 30 armv7l and it has no difference in testsuite (except for the added/removed testcase of this D63540 <https://reviews.llvm.org/D63540>).
In both cases I get these:

  Unexpected Passing Tests (5):
      lldb-api :: functionalities/archives/TestBSDArchives.py
      lldb-api :: functionalities/inferior-assert/TestInferiorAssert.py
      lldb-api :: functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py
      lldb-api :: linux/builtin_trap/TestBuiltinTrap.py
      lldb-api :: linux/thread/create_during_instruction_step/TestCreateDuringInstructionStep.py
  Failing Tests (103):
      lldb-api :: commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py
      lldb-api :: commands/expression/call-function/TestCallStdStringFunction.py
      lldb-api :: commands/expression/call-function/TestCallStopAndContinue.py
      lldb-api :: commands/expression/call-function/TestCallUserDefinedFunction.py
      lldb-api :: commands/expression/call-overridden-method/TestCallOverriddenMethod.py
      lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py
      lldb-api :: commands/expression/char/TestExprsChar.py
      lldb-api :: commands/expression/class_template_specialization_empty_pack/TestClassTemplateSpecializationParametersHandling.py
      lldb-api :: commands/expression/context-object/TestContextObject.py
      lldb-api :: commands/expression/dont_allow_jit/TestAllowJIT.py
      lldb-api :: commands/expression/entry-bp/TestExprEntryBP.py
      lldb-api :: commands/expression/expr-in-syscall/TestExpressionInSyscall.py
      lldb-api :: commands/expression/formatters/TestFormatters.py
      lldb-api :: commands/expression/inline-namespace/TestInlineNamespace.py
      lldb-api :: commands/expression/no-deadlock/TestExprDoesntBlock.py
      lldb-api :: commands/expression/persistent_types/TestNestedPersistentTypes.py
      lldb-api :: commands/expression/persistent_types/TestPersistentTypes.py
      lldb-api :: commands/expression/pr35310/TestExprsBug35310.py
      lldb-api :: commands/expression/radar_9531204/TestPrintfAfterUp.py
      lldb-api :: commands/expression/radar_9673664/TestExprHelpExamples.py
      lldb-api :: commands/expression/rdar44436068/Test128BitsInteger.py
      lldb-api :: commands/expression/static-initializers/TestStaticInitializers.py
      lldb-api :: commands/expression/test/TestExprs.py
      lldb-api :: commands/expression/timeout/TestCallWithTimeout.py
      lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py
      lldb-api :: commands/expression/xvalue/TestXValuePrinting.py
      lldb-api :: commands/register/register/register_command/TestRegisters.py
      lldb-api :: commands/watchpoints/hello_watchlocation/TestWatchLocation.py
      lldb-api :: commands/watchpoints/multi_watchpoint_slots/TestWatchpointMultipleSlots.py
      lldb-api :: commands/watchpoints/watchpoint_size/TestWatchpointSizes.py
      lldb-api :: functionalities/breakpoint/require_hw_breakpoints/TestRequireHWBreakpoints.py
      lldb-api :: functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py
      lldb-api :: functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py
      lldb-api :: functionalities/load_unload/TestLoadUnload.py
      lldb-api :: functionalities/load_using_paths/TestLoadUsingPaths.py
      lldb-api :: functionalities/memory/find/TestMemoryFind.py
      lldb-api :: functionalities/process_group/TestChangeProcessGroup.py
      lldb-api :: functionalities/return-value/TestReturnValue.py
      lldb-api :: functionalities/show_location/TestShowLocationDwarf5.py
      lldb-api :: functionalities/thread/num_threads/TestNumThreads.py
      lldb-api :: lang/c/bitfields/TestBitfields.py
      lldb-api :: lang/c/function_types/TestFunctionTypes.py
      lldb-api :: lang/c/shared_lib/TestSharedLib.py
      lldb-api :: lang/c/strings/TestCStrings.py
      lldb-api :: lang/c/struct_types/TestStructTypes.py
      lldb-api :: lang/cpp/auto/TestCPPAuto.py
      lldb-api :: lang/cpp/call-function/TestCallCPPFunction.py
      lldb-api :: lang/cpp/chained-calls/TestCppChainedCalls.py
      lldb-api :: lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
      lldb-api :: lang/cpp/extern_c/TestExternCSymbols.py
      lldb-api :: lang/cpp/global_operators/TestCppGlobalOperators.py
      lldb-api :: lang/cpp/lambdas/TestLambdas.py
      lldb-api :: lang/cpp/llvm-style/TestLLVMStyle.py
      lldb-api :: lang/cpp/namespace/TestNamespace.py
      lldb-api :: lang/cpp/namespace/TestNamespaceLookup.py
      lldb-api :: lang/cpp/namespace_conflicts/TestNamespaceConflicts.py
      lldb-api :: lang/cpp/namespace_definitions/TestNamespaceDefinitions.py
      lldb-api :: lang/cpp/operators/TestCppOperators.py
      lldb-api :: lang/cpp/overloaded-functions/TestOverloadedFunctions.py
      lldb-api :: lang/cpp/rvalue-references/TestRvalueReferences.py
      lldb-api :: lang/cpp/scope/TestCppScope.py
      lldb-api :: lang/cpp/static_methods/TestCPPStaticMethods.py
      lldb-api :: lang/cpp/symbols/TestSymbols.py
      lldb-api :: lang/cpp/template-function/TestTemplateFunctions.py
      lldb-api :: lang/cpp/template/TestTemplateArgs.py
      lldb-api :: lang/cpp/this/TestCPPThis.py
      lldb-api :: lang/cpp/trivial_abi/TestTrivialABI.py
      lldb-api :: lang/cpp/unicode-literals/TestUnicodeLiterals.py
      lldb-api :: lang/cpp/virtual/TestVirtual.py
      lldb-api :: python_api/thread/TestThreadAPI.py
      lldb-api :: tools/lldb-server/TestLldbGdbServer.py
      lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_INTERP.yaml
      lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-PT_TLS.yaml
      lldb-shell :: ObjectFile/ELF/PT_LOAD-overlap-section.yaml
      lldb-shell :: ObjectFile/ELF/PT_LOAD.yaml
      lldb-shell :: ObjectFile/ELF/PT_TLS-overlap-PT_LOAD.yaml
      lldb-shell :: ObjectFile/ELF/minidebuginfo-set-and-hit-breakpoint.test
      lldb-shell :: Reproducer/Functionalities/TestDataFormatter.test
      lldb-shell :: Reproducer/Functionalities/TestImageList.test
      lldb-shell :: Reproducer/Functionalities/TestStepping.test
      lldb-shell :: Reproducer/TestDump.test
      lldb-shell :: Reproducer/TestGDBRemoteRepro.test
      lldb-shell :: Reproducer/TestRelativePath.test
      lldb-shell :: Reproducer/TestReuseDirectory.test
      lldb-shell :: Reproducer/TestSynchronous.test
      lldb-shell :: Reproducer/TestWorkingDir.test
      lldb-shell :: SymbolFile/DWARF/anon_class_w_and_wo_export_symbols.ll
      lldb-shell :: SymbolFile/DWARF/clang-ast-from-dwarf-unamed-and-anon-structs.cpp
      lldb-shell :: SymbolFile/DWARF/debug-types-expressions.test
      lldb-shell :: SymbolFile/NativePDB/ast-functions.cpp
      lldb-shell :: SymbolFile/NativePDB/ast-methods.cpp
      lldb-shell :: SymbolFile/NativePDB/ast-types.cpp
      lldb-shell :: SymbolFile/NativePDB/bitfields.cpp
      lldb-shell :: SymbolFile/NativePDB/break-by-function.cpp
      lldb-shell :: SymbolFile/NativePDB/break-by-line.cpp
      lldb-shell :: SymbolFile/NativePDB/function-types-builtins.cpp
      lldb-shell :: SymbolFile/NativePDB/function-types-classes.cpp
      lldb-shell :: SymbolFile/NativePDB/global-classes.cpp
      lldb-shell :: SymbolFile/NativePDB/globals-bss.cpp
      lldb-shell :: SymbolFile/NativePDB/globals-fundamental.cpp
      lldb-shell :: SymbolFile/NativePDB/nested-types.cpp
      lldb-shell :: SymbolFile/NativePDB/source-list.cpp
      lldb-shell :: SymbolFile/NativePDB/tag-types.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540

More information about the llvm-commits mailing list