[PATCH] D70146: [ELF] Improve --gc-sections compatibility with GNU ld regarding section groups

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

This looks good to me too.



================
Comment at: lld/ELF/InputSection.h:147
+  // used by --gc-sections.
+  InputSectionBase *nextInGroup = nullptr;
+
----------------
ruiu wrote:
> MaskRay wrote:
> > ruiu wrote:
> > > I'd probably name this sectionGroupNextMember or something like that, so that it is clear that "group" means "section group".
> > What about `nextInSectionGroup`?
> > 
> > @peter.smith What do you think?
> > 
> > (I confess that in BFD, a member serving a similar purpose is named `next_in_group`.)
> That's fine too. I honestly don't think next_in_group is a good name, as we use "group" for other meanings such as --start-group.
Yes nextInSectionGroup is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70146/new/

https://reviews.llvm.org/D70146