[compiler-rt] 1689ad2 - [builtins] Implement rounding mode support for i386/x86_64

[Hans Wennborg via llvm-commits]

I've reverted this in a19f0eec94e, as it broke the build with MSVC
(see e.g. http://lab.llvm.org:8011/builders/sanitizer-windows/builds/54305)

On Mon, Nov 18, 2019 at 7:36 PM Yi Kong via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Yi Kong
> Date: 2019-11-18T10:32:40-08:00
> New Revision: 1689ad27af5c5712f42542807eb4ecdfe84c2eca
>
> URL: https://github.com/llvm/llvm-project/commit/1689ad27af5c5712f42542807eb4ecdfe84c2eca
> DIFF: https://github.com/llvm/llvm-project/commit/1689ad27af5c5712f42542807eb4ecdfe84c2eca.diff
>
> LOG: [builtins] Implement rounding mode support for i386/x86_64
>
> Differential Revision: https://reviews.llvm.org/D69870
>
> Added:
>     compiler-rt/lib/builtins/i386/fp_mode.c
>
> Modified:
>     compiler-rt/lib/builtins/CMakeLists.txt
>     compiler-rt/test/builtins/Unit/addtf3_test.c
>     compiler-rt/test/builtins/Unit/subtf3_test.c
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/compiler-rt/lib/builtins/CMakeLists.txt b/compiler-rt/lib/builtins/CMakeLists.txt
> index 1d3d65a9940a..207980c8e0a4 100644
> --- a/compiler-rt/lib/builtins/CMakeLists.txt
> +++ b/compiler-rt/lib/builtins/CMakeLists.txt
> @@ -239,6 +239,7 @@ set(x86_ARCH_SOURCES
>    floatuntixf.c
>    mulxc3.c
>    powixf2.c
> +  i386/fp_mode.c
>  )
>
>  if (NOT MSVC)
>
> diff  --git a/compiler-rt/lib/builtins/i386/fp_mode.c b/compiler-rt/lib/builtins/i386/fp_mode.c
> new file mode 100644
> index 000000000000..62ab771222c0
> --- /dev/null
> +++ b/compiler-rt/lib/builtins/i386/fp_mode.c
> @@ -0,0 +1,39 @@
> +//===----- lib/i386/fp_mode.c - Floaing-point mode utilities -----*- C -*-====//
> +//
> +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
> +// See https://llvm.org/LICENSE.txt for license information.
> +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
> +//
> +//===----------------------------------------------------------------------===//
> +
> +#include "../fp_mode.h"
> +
> +#define X87_TONEAREST  0x0000
> +#define X87_DOWNWARD   0x0400
> +#define X87_UPWARD     0x0800
> +#define X87_TOWARDZERO 0x0c00
> +#define X87_RMODE_MASK (X87_TONEAREST | X87_UPWARD | X87_DOWNWARD | X87_TOWARDZERO)
> +
> +FE_ROUND_MODE __fe_getround() {
> +  // Assume that the rounding mode state for the fpu agrees with the SSE unit.
> +  unsigned short cw;
> +  __asm__ __volatile__ ("fnstcw %0" : "=m" (cw));
> +
> +  switch (cw & X87_RMODE_MASK) {
> +    case X87_TONEAREST:
> +      return FE_TONEAREST;
> +    case X87_DOWNWARD:
> +      return FE_DOWNWARD;
> +    case X87_UPWARD:
> +      return FE_UPWARD;
> +    case X87_TOWARDZERO:
> +      return FE_TOWARDZERO;
> +  }
> +  return FE_TONEAREST;
> +}
> +
> +int __fe_raise_inexact() {
> +  float f = 1.0f, g = 3.0f;
> +  __asm__ __volatile__ ("fdivs %1" : "+t" (f) : "m" (g));
> +  return 0;
> +}
>
> diff  --git a/compiler-rt/test/builtins/Unit/addtf3_test.c b/compiler-rt/test/builtins/Unit/addtf3_test.c
> index 7ca0355e42ad..dcd4efe9c901 100644
> --- a/compiler-rt/test/builtins/Unit/addtf3_test.c
> +++ b/compiler-rt/test/builtins/Unit/addtf3_test.c
> @@ -76,7 +76,8 @@ int main()
>                       UINT64_C(0x61e58dd6c51eb77c)))
>          return 1;
>
> -#if (defined(__arm__) || defined(__aarch64__)) && defined(__ARM_FP)
> +#if (defined(__arm__) || defined(__aarch64__)) && defined(__ARM_FP) || \
> +    defined(i386) || defined(__x86_64__)
>      // Rounding mode tests on supported architectures
>      const long double m = 1234.0L, n = 0.01L;
>
>
> diff  --git a/compiler-rt/test/builtins/Unit/subtf3_test.c b/compiler-rt/test/builtins/Unit/subtf3_test.c
> index b95f2ef996d6..265ab642ecf0 100644
> --- a/compiler-rt/test/builtins/Unit/subtf3_test.c
> +++ b/compiler-rt/test/builtins/Unit/subtf3_test.c
> @@ -69,7 +69,8 @@ int main()
>                       UINT64_C(0xa44a7bca780a166c)))
>          return 1;
>
> -#if (defined(__arm__) || defined(__aarch64__)) && defined(__ARM_FP)
> +#if (defined(__arm__) || defined(__aarch64__)) && defined(__ARM_FP) || \
> +    defined(i386) || defined(__x86_64__)
>      // Rounding mode tests on supported architectures
>      const long double m = 1234.02L, n = 0.01L;
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits