[PATCH] D70146: [ELF] Improve --gc-sections compatibility with GNU ld regarding section groups

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/InputSection.h:147
+  // used by --gc-sections.
+  InputSectionBase *nextInGroup = nullptr;
+
----------------
MaskRay wrote:
> ruiu wrote:
> > I'd probably name this sectionGroupNextMember or something like that, so that it is clear that "group" means "section group".
> What about `nextInSectionGroup`?
> 
> @peter.smith What do you think?
> 
> (I confess that in BFD, a member serving a similar purpose is named `next_in_group`.)
That's fine too. I honestly don't think next_in_group is a good name, as we use "group" for other meanings such as --start-group.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70146/new/

https://reviews.llvm.org/D70146