[PATCH] D70146: [ELF] Improve --gc-sections compatibility with GNU ld regarding section groups

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 23:35:14 PST 2019


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/InputSection.h:147
+  // used by --gc-sections.
+  InputSectionBase *nextInGroup = nullptr;
+
----------------
ruiu wrote:
> I'd probably name this sectionGroupNextMember or something like that, so that it is clear that "group" means "section group".
What about `nextInSectionGroup`?

@peter.smith What do you think?

(I confess that in BFD, a member serving a similar purpose is named `next_in_group`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70146/new/

https://reviews.llvm.org/D70146





More information about the llvm-commits mailing list