[PATCH] D70374: [PowerPC] combine rlwinm + rlwinm to rlwinm

[qshanz via Phabricator via llvm-commits]

steven.zhang accepted this revision.
steven.zhang added a comment.
This revision is now accepted and ready to land.

LGTM with some minor nit. But please wait for some days if some one else have more comments.



================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:873
+        }
+
+        uint32_t NewMB, NewME;
----------------
Personally, I prefer to add a else here to make the code more clear, then, you don't need the break in line 871 any more. Anyway, it depends on you.


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:877
+          // About to replace MI.getOperand(1), clear its kill flag.
+          MI.getOperand(1).setIsKill(false);
+
----------------
I think, this should be moved to line 900 as else clause.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70374/new/

https://reviews.llvm.org/D70374