[PATCH] D70246: [InstCombine] remove identity shuffle simplification for mask with undefs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 17:58:32 PST 2019


efriedma added a comment.

My biggest concern here is the interaction with SimplifyDemandedVectorElts; previously, the way the interaction worked is that SimplifyDemandedVectorElts would change the shuffle indexes to undef, then later combines could remove those shuffles.  That doesn't work anymore because of this rule.

We can probably recover some cases by adding a little extra code to SimplifyDemandedVectorElts, to eliminate shuffles where the demanded elements correspond to an identity shuffle.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70246/new/

https://reviews.llvm.org/D70246





More information about the llvm-commits mailing list