[PATCH] D69032: [APInt] add wrapping support for APInt::setBits

Mon Nov 18 17:58:31 PST 2019

shchenz updated this revision to Diff 229954.
shchenz marked an inline comment as done.
shchenz added a comment.

Use two interface `getBitsSet` and `getBitsSetWithWrap`.

To be honest, I don't like this fix, it is a patch-like fix. In order to protect legacy usage, we create two functionally overlapping interfaces for both `getBitsSet` and `setBits`. But I can not find another better way to not change legacy usage for these functions, so let it be like now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69032/new/

https://reviews.llvm.org/D69032

Files:
  llvm/include/llvm/ADT/APInt.h
  llvm/unittests/ADT/APIntTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69032.229954.patch
Type: text/x-patch
Size: 4453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191119/22f68b4c/attachment.bin>