[PATCH] D70226: Add an option to disable strict float node mutating to an normal float node

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 17:58:31 PST 2019


pengfei added a comment.

> My main point is that the difference between 1) and 3) has to be determined on a case-by-case basis by inspecting the particular expansion sequence, and therefore this should be checked in-line in each expansion sequence.  This is why I'd prefer to have each affected custom expansion sequence implementation directly the flag check whether or not strict semantics must be enforced or not; I don't believe this can be a single check just at the top of ExpandNode.

Thanks for the explanation! It very helpful for us to understand the workflow of strict semantics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70226/new/

https://reviews.llvm.org/D70226





More information about the llvm-commits mailing list