[PATCH] D70376: [LVI] Restructure caching

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 16:36:49 PST 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

Simpler is good, I think.  And I like the use of AssertingVH.  LGTM.

It would be nice to have a testcase for PR43909?  But not critical, I think; the expanded use of AssertingVH should catch any future issues here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70376/new/

https://reviews.llvm.org/D70376





More information about the llvm-commits mailing list