[PATCH] D70065: [test-suite] Add sollve_vv external project.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: External/sollve_vv/CMakeLists.txt:53
+
+llvm_externals_find(TEST_SUITE_SOLLVEVV_ROOT "sollve_vv" "OpenMP Offloading Validation & Verification Suite")
+if (TEST_SUITE_SOLLVEVV_ROOT)
----------------
homerdin wrote:
> It would be nice to be able to checkout the suite into this directory and have it picked up automatically.  I don't know enough about the other external suites to know if this should be put into the `llvm_externals_find` logic.  We could add 
> 
> ```
> if( NOT TEST_SUITE_SOLLVEVV_ROOT)
>   if( IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/sollve_vv")
>     set(TEST_SUITE_SOLLVEVV_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/sollve_vv")
>   endif()
> endif()
> ```
The test-suite has a standard way to look for external source files. See the command `llvm_externals_find` in `cmake/modules/External.cmake`. I also added it to the README.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70065/new/

https://reviews.llvm.org/D70065