[PATCH] D70243: Lowering CPI/JTI/BA to assembly

Mon Nov 18 15:52:51 PST 2019

sfertile accepted this revision.
sfertile added a comment.

Other then the few nits I mentioned LGTM.

In D70243#1750631 <https://reviews.llvm.org/D70243#1750631>, @jasonliu wrote:

> Sorry, please ignore the test did not come clean comments. I realized my branch did not have D70182 <https://reviews.llvm.org/D70182> in it. After pulling it in, the test works as expected. 
>  I will continue my review.

I did the same thing :)

================
Comment at: llvm/test/CodeGen/PowerPC/aix-lower-constant-pool-index.ll:87
+; CHECK: .toc
+; CHECK-NOT: .tc
----------------
sfertile wrote:
> I don't understand why we have a check-not in each of the tests for `.tc`. Is it because we haven't implemented the emission of the toc entries yet and its a reminder to fixup the test when we do implement that?
Spoke offline with @Xiangling_L and the CHECK-NOTS are there so we can update the tests when we start writing out the toc entries.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70243/new/

https://reviews.llvm.org/D70243