[PATCH] D70148: [SLP] fix miscompile on min/max reductions with extra uses (PR43948)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 15:40:54 PST 2019
spatel reopened this revision.
spatel added a comment.
This revision is now accepted and ready to land.
Reopening - reverted here:
rG6f1cc4151a5a <https://reviews.llvm.org/rG6f1cc4151a5ad297b2d1d87d98e266f9729100e2>
Looks like we need to adjust the IR insert point for the cmp (the whole reduction?) because we may create invalid IR otherwise ("Instruction does not dominate all uses!").
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70148/new/
https://reviews.llvm.org/D70148
More information about the llvm-commits
mailing list