[PATCH] D69771: [APFloat] Handle exponent underflow correctly
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 15:23:01 PST 2019
efriedma added inline comments.
================
Comment at: llvm/include/llvm/ADT/APFloat.h:146
/// A signed type to represent a floating point numbers unbiased exponent.
- typedef signed short ExponentType;
+ typedef int32_t ExponentType;
----------------
What's the effect of this on the size of APFloat on a 64-bit target? On a 32-bit target?
================
Comment at: llvm/lib/Support/APFloat.cpp:994
+ // Save the addend now, before we change our properties, as it may be equal to
+ // 'this' pointer.
+ if (addend)
----------------
Does this have some functional effect? If it does, is there a test?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69771/new/
https://reviews.llvm.org/D69771
More information about the llvm-commits
mailing list