[PATCH] D70250: [llvm-cxxfilt] Improve strip-underscore behavior

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:78
+
 static std::string demangle(llvm::raw_ostream &OS, const std::string &Mangled) {
   int Status;
----------------
Side comment: Why does this function take an ostream then only write "import thunk for" into it? Looks like that will produce broken output for import thunks in the `Split` case in demangleLine. Can't we just return a string with "import thunk for" prefixed in that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70250/new/

https://reviews.llvm.org/D70250