[llvm] 9b36f2c - Fix iOSDarwin()'s doc comment.

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 13:24:23 PST 2019


Author: Cyndy Ishida
Date: 2019-11-18T13:18:06-08:00
New Revision: 9b36f2cfd98d56531b95c1f62976c01b65a0c18b

URL: https://github.com/llvm/llvm-project/commit/9b36f2cfd98d56531b95c1f62976c01b65a0c18b
DIFF: https://github.com/llvm/llvm-project/commit/9b36f2cfd98d56531b95c1f62976c01b65a0c18b.diff

LOG: Fix iOSDarwin()'s doc comment.

Summary:
I saw the doc comment using the Option + Click in Xcode and I was
confused by the fact that tvOS wasn't listed. The method definition
also doesn't make it clear that the check for tvOS is taking place as
the tvOS check is hidden in the isiOS() check.

Reviewers: rjmccall

Reviewed By: rjmccall

Subscribers: dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70364

This patch is from Varun Gandhi <varun_gandhi at apple.com>

Added: 
    

Modified: 
    llvm/include/llvm/ADT/Triple.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ADT/Triple.h b/llvm/include/llvm/ADT/Triple.h
index edeb31efab80..b9485e81feb7 100644
--- a/llvm/include/llvm/ADT/Triple.h
+++ b/llvm/include/llvm/ADT/Triple.h
@@ -477,7 +477,7 @@ class Triple {
     return getSubArch() == Triple::ARMSubArch_v7k;
   }
 
-  /// isOSDarwin - Is this a "Darwin" OS (OS X, iOS, or watchOS).
+  /// isOSDarwin - Is this a "Darwin" OS (macOS, iOS, tvOS or watchOS).
   bool isOSDarwin() const {
     return isMacOSX() || isiOS() || isWatchOS();
   }


        


More information about the llvm-commits mailing list