[PATCH] D70353: test-release.sh: Update to fetch source from GitHub

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 11:35:53 PST 2019


tstellar marked 4 inline comments as done.
tstellar added inline comments.


================
Comment at: llvm/utils/release/test-release.sh:293
 function export_sources() {
-    check_valid_urls
-
-    for proj in $projects ; do
-        case $proj in
-        llvm)
-            projsrc=$proj.src
-            ;;
-        cfe)
-            projsrc=llvm.src/tools/clang
-            ;;
-        lld|lldb|polly)
-            projsrc=llvm.src/tools/$proj
-            ;;
-        clang-tools-extra)
-            projsrc=llvm.src/tools/clang/tools/extra
-            ;;
-        compiler-rt|libcxx|libcxxabi|libunwind|openmp)
-            projsrc=llvm.src/projects/$proj
-            ;;
-        test-suite)
-            projsrc=$proj.src
-            ;;
-        *)
-            echo "error: unknown project $proj"
-            exit 1
-            ;;
-        esac
+  tag="llvmorg-$Release"
+  if [ "$RC" != "final" ]; then
----------------
hans wrote:
> I guess this won't work with -svn-path, which I like to use to test a branch before tagging it.
> 
> It would be great if we could rename that to -git-ref or something and have it work the same way.
I've added an equivalent option called -git-ref.  The only difference is if you pass it a raw sha, then it won't be able to checkout the test-suite, since it is in a different repository.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70353/new/

https://reviews.llvm.org/D70353





More information about the llvm-commits mailing list