[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

Melanie Blower via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 10:59:28 PST 2019


mibintc added a comment.

The incorrect code is actually in the IRBuilder which is part of a different patch...

In D62731#1750312 <https://reviews.llvm.org/D62731#1750312>, @echristo wrote:

> In D62731#1749916 <https://reviews.llvm.org/D62731#1749916>, @mibintc wrote:
>
> > Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null.  I start by adding a null pointer check.
>
>
> Had a crash on valid here for days, let's revert and then get a fix when recommitting. I'll respond to the thread when reverting. Thanks :)





Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62731/new/

https://reviews.llvm.org/D62731





More information about the llvm-commits mailing list