[compiler-rt] b87fc09 - Bump sanitizer macOS deployment target to 10.10

[Julian Lettner via llvm-commits]

Author: Julian Lettner
Date: 2019-11-18T09:41:18-08:00
New Revision: b87fc09dceeff9cb838884961d817c0ab0257176

URL: https://github.com/llvm/llvm-project/commit/b87fc09dceeff9cb838884961d817c0ab0257176
DIFF: https://github.com/llvm/llvm-project/commit/b87fc09dceeff9cb838884961d817c0ab0257176.diff

LOG: Bump sanitizer macOS deployment target to 10.10

Bump default value for `SANITIZER_MIN_OSX_VERSION` to 10.10 (from 10.9).
TSan does not work on macOS 10.9 and a nice error message is preferable
to an "unreferenced symbol" error when loading the TSan runtime.

We could try to only bump the deployment target for TSan, but we would
have to invest into adding support for this to our CMake build and it
does not seem worth it.  macOS 10.10 was released in 2014.

rdar://31335781

Added: 
    

Modified: 
    compiler-rt/cmake/config-ix.cmake

Removed: 
    


################################################################################
diff  --git a/compiler-rt/cmake/config-ix.cmake b/compiler-rt/cmake/config-ix.cmake
index f08a3c59bdbd..3a3e03a01aeb 100644
--- a/compiler-rt/cmake/config-ix.cmake
+++ b/compiler-rt/cmake/config-ix.cmake
@@ -357,14 +357,14 @@ if(APPLE)
     elseif(CMAKE_OSX_DEPLOYMENT_TARGET)
       set(SANITIZER_MIN_OSX_VERSION ${CMAKE_OSX_DEPLOYMENT_TARGET})
     else()
-      set(SANITIZER_MIN_OSX_VERSION 10.9)
+      set(SANITIZER_MIN_OSX_VERSION 10.10)
     endif()
     if(SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.7")
       message(FATAL_ERROR "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too old.")
     endif()
-    if(SANITIZER_MIN_OSX_VERSION VERSION_GREATER "10.9")
-      message(WARNING "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too new, setting to '10.9' instead.")
-      set(SANITIZER_MIN_OSX_VERSION 10.9)
+    if(SANITIZER_MIN_OSX_VERSION VERSION_GREATER "10.10")
+      message(WARNING "macOS deployment target '${SANITIZER_MIN_OSX_VERSION}' is too new, setting to '10.10' instead.")
+      set(SANITIZER_MIN_OSX_VERSION 10.10)
     endif()
   endif()