[PATCH] D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 08:44:52 PST 2019


rjmccall added inline comments.


================
Comment at: llvm/test/Transforms/ObjCARC/inlined-autorelease-return-value.ll:114
+  ret i8* %c
+}
+
----------------
dexonsmith wrote:
> rjmccall wrote:
> > Do you want to add a test for when there's any sort of interference besides just being in separate blocks?  Or for when there are bitcasts?
> Yes, I'll add both of those.  For interference, is it enough to put a call to `llvm.objc.retain` in between, or is there something else worth testing?
Maybe also an opaque call.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70370/new/

https://reviews.llvm.org/D70370





More information about the llvm-commits mailing list