[PATCH] D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 08:44:49 PST 2019


daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wuzish.

LGTM



================
Comment at: llvm/lib/MC/MCSectionXCOFF.cpp:66
+           "don't understand how to switch to.");
+    OS << "\t.csect " << QualName->getName() << '\n';
+    return;
----------------
aside: we should probably eventually think about simplifying and cleaning up the logic in this function since we almost always just want to print `.csect QUALNAME` after asserting some things for unimplemented features


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70310/new/

https://reviews.llvm.org/D70310





More information about the llvm-commits mailing list