[PATCH] D70399: [llvm-readobj/llvm-readelf] - Improve dumping of versioning sections.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht, ruiu.
Herald added subscribers: seiya, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar updated this revision to Diff 229851.
grimar added a comment.

- Last minute fix.


Our elf-versioninfo.test is not perfect. It does not properly test how
flags are dumped and also we have a bug: they are dumped as enums in
LLVM style now, i.e not dumped properly.

GNU style uses a `versionFlagToString` method to build a string from flags
which seems is consistent with GNU readelf.

In this patch I fixed the issues mentioned.


https://reviews.llvm.org/D70399

Files:
  lld/test/ELF/verdef-defaultver.s
  lld/test/ELF/verdef-dependency.s
  lld/test/ELF/verdef.s
  llvm/test/tools/llvm-readobj/elf-invalid-versioning.test
  llvm/test/tools/llvm-readobj/elf-versioninfo.test
  llvm/test/tools/yaml2obj/verdef-section.yaml
  llvm/test/tools/yaml2obj/verneed-section.yaml
  llvm/test/tools/yaml2obj/versym-section.yaml
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70399.229851.patch
Type: text/x-patch
Size: 18126 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191118/7726c401/attachment.bin>