[PATCH] D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 07:24:54 PST 2019


Xiangling_L added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:154
   CsectGroup DataCsects;
+  CsectGroup TOCCsects;
   CsectGroup BSSCsects;
----------------
I am not quite sure, but my understanding is that we only have one TOC base csect in one translation unit? If I am correct, do we want to name this `TOCCsect` or add a comment to specify that point? It's a little confused to see plural here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70271/new/

https://reviews.llvm.org/D70271





More information about the llvm-commits mailing list