[PATCH] D70293: Fix PR44001: assert failure in getFunctionLocalOffsetAfterInsn

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D70293#1749752 <https://reviews.llvm.org/D70293#1749752>, @dstenb wrote:

> This seems good!
>
> As @djtodoro mentions, a test case which verifies the DWARF output would be good.
>
> Downstream we have had some unrelated issues with requesting labels for bundled MIs, which we solved with making the `requestLabel*()` and `getLabel*()` functions do `getBundleStart()` for bundled instructions. We can probably look towards using the same approach as here for the issue(s) which caused us to add that bundle handling in the first case, and see if it's possible/valuable to upstream that. If so, the `requestLabel*()` and `getLabel*()` functions should probably have `!isInsideBundle()` assertions.


I believe labels get inserted in other places as well which might add some labels on actual MIs rather than bundle MIs so I'm not sure assert in those function would be appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70293/new/

https://reviews.llvm.org/D70293