[PATCH] D70237: [X86] Add more addcarry tests

Mon Nov 18 04:52:16 PST 2019

davezarzycki added a comment.

In D70237#1749635 <https://reviews.llvm.org/D70237#1749635>, @chfast wrote:

> I ended up with optimizing my bigint library. The end result is - add_U256_without_i128_or_recursive which works better in current LLVM release and is also nicely reduced by D70079 <https://reviews.llvm.org/D70079>.
>  The analogous implementations of subtraction is added as sub_U256_without_i128_or_recursive test. This one should be interested to you @davezarzycki, your changes make it better, but it looks it is not perfect yet.

Thanks for the update. Where is the original source for sub_U256_without_i128_or_recursive? The IR is strange. It seems to use two different strategies for merging carry flags.

And as a reminder, please remove the URLs from the test files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70237/new/

https://reviews.llvm.org/D70237