[PATCH] D70112: [llvm-readobj] - Improve dumping of the SHT_LLVM_LINKER_OPTIONS sections.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 04:43:38 PST 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM with two nits.
================
Comment at: llvm/test/tools/llvm-readobj/elf-linker-options.test:11
+# CHECK-EMPTY:
+# CHECK-NEXT: warning: '[[FILE]]': SHT_LLVM_LINKER_OPTIONS section at index 2 is broken: an incomplete key-value pair was found. The last possible key was: "c
+# CHECK-EMPTY:
----------------
'"c' -> "c"?
================
Comment at: llvm/test/tools/llvm-readobj/elf-linker-options.test:49
+ Content: "61"
+## Case 5: a one more correct case to show we do not stop dumping after reporting a warning.
+ - Name: .linker-options.valid2
----------------
a one more -> another
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70112/new/
https://reviews.llvm.org/D70112
More information about the llvm-commits
mailing list