[PATCH] D69032: [APInt] add wrapping support for APInt::setBits

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 02:10:34 PST 2019


craig.topper added a comment.

I think setBitsWithWrap should call setBits if there is no wrap and call setLowBits and setHighBits if there is wrap. Matching the behavior setBits used to have. Any incorrect comments on setBits or getBitsSet should be fixed.

This gives places that want wrap the support they need inside of a APInt but doesn’t slow down or increase the code size of any of the existing callers of setBits.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69032/new/

https://reviews.llvm.org/D69032





More information about the llvm-commits mailing list