[PATCH] D70264: [yaml2obj][test] Move tests to binary format specific subdirectories
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 01:56:06 PST 2019
jhenderson accepted this revision.
jhenderson added a comment.
LGTM, with one suggestion.
================
Comment at: llvm/test/tools/yaml2obj/ELF/empty-symbols.yaml:10
+ Machine: EM_X86_64
+# We usually express this as `Symbols: []` but we are testing omitted value here.
+Symbols:
----------------
grimar wrote:
> `#` -> `##`
This phrasing sounds a bit clunky to me. How about "... but here we show that the value can be omitted."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70264/new/
https://reviews.llvm.org/D70264
More information about the llvm-commits
mailing list