[PATCH] D70298: [LV] Avoid considering scalar-with-predication instructions as also uniform-after-vectorization, fix PR40816
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 18 01:43:01 PST 2019
Ayal marked an inline comment as done.
Ayal added a comment.
In D70298#1749366 <https://reviews.llvm.org/D70298#1749366>, @uabelho wrote:
> In D70298#1747644 <https://reviews.llvm.org/D70298#1747644>, @uabelho wrote:
>
> > Nice! This indeed seems to solve the problem we saw in PR40816.
> >
> > I don't know the code but I can at least provide some additional testing by including this patch in my weekend testing to see nothing unexpected pops up there.
>
>
> Testing went well!
Thanks Mikael, good to know!
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4682
+ else
+ LLVM_DEBUG(dbgs() << "LV: Found not uniform being ScalarWithPredication: "
+ << *I << "\n");
----------------
LLVM_DEBUG is redundant under #ifndef NDEBUG, will remove.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70298/new/
https://reviews.llvm.org/D70298
More information about the llvm-commits
mailing list