[PATCH] D70146: [ELF] Improve --gc-sections compatibility with GNU ld regarding section groups

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/linkerscript/discard-group.s:1
+# REQUIRES: arm
+## For --gc-sections, group members are retained or discarded as a unit.
----------------
MaskRay wrote:
> grimar wrote:
> > Why arm? Can this be x86?
> The intention is to create a practical use case which is more practical. It demonstrates the advantage that makes section group selection and garbage collection orthogonal for group members.  https://sourceware.org/ml/binutils/2019-11/msg00210.html 
> 
> .fnstart creates an associated section (`.ARM.exidx*`) in the section group, while `.cfi_startproc` creates `.eh_frame` outside the group.
Ok, I see now, thanks.

> .fnstart creates an associated section (.ARM.exidx*) in the section group

Perhaps I'd mention this in the comments in this test case, for readers who are not so familar with arm (like me).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70146/new/

https://reviews.llvm.org/D70146