[PATCH] D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate

Mon Nov 18 00:37:05 PST 2019

hans added a comment.

Please reference PR43425 in the patch description. I don't know if the reproducer from there can be used as a test case, but at least it should be possible to use to check this works manually.

================
Comment at: compiler-rt/lib/profile/InstrProfilingUtil.c:222

+  if (lprofLockFd(fd) != 0)
+    PROF_WARN("Data may be corrupted during profile merging : %s\n",
----------------
Does lprofLockFd work on Windows? It looks like it just calls flock() but I didn't know that's a Windows thing?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70330/new/

https://reviews.llvm.org/D70330